Re: [PATCH 2/4] power: reset: add PSCRR NVMEM recorder
Uwe Kleine-König <[email protected]>
| Newsgroups | org.kernel.vger.linux-arm-msm |
|---|---|
| Message-ID | <aoQe4dvuUtHOZ0jg@monoceros> |
Hello,
On Mon, Aug 17, 2026 at 06:59:42PM +0530, Faruque Ansari wrote:
> +#include <linux/mod_devicetable.h>
> +#include <linux/module.h>
> +#include <linux/nvmem-consumer.h>
> +#include <linux/platform_device.h>
> +#include <linux/pscrr.h>
> +#include <linux/reboot.h>
> +#include <linux/slab.h>
Please rely on <linux/platform_device.h> to provide of_device_id and
drop <linux/mod_devicetable.h>. The latter header will go away soon (and
<linux/platform_device.h> only includes <linux/device-id/platform.h>
which introduces much less dependencies.)
> [...]
> +static const struct of_device_id pscrr_nvmem_of_match[] = {
> + { .compatible = "pscrr-nvmem" },
> + {}
{ } please (i.e. add a space)
> +};
> +MODULE_DEVICE_TABLE(of, pscrr_nvmem_of_match);
Best regards
Uwe
signature.asc
(application/pgp-signature, 488 B)
-----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmqEH7IACgkQj4D7WH0S /k4CJggAp9uDCUWRCiyr2147aanmWPbdc7axHmbE3IvRbuv2L/D4B+lMbboRWYAt 52J++aQF/9SPP2l90lZZ53SHpgHJ0ozF2g5YU9lq5dYUr3xOvGR8MmR2s3jwpyvc 9UDrbDCswAFXWMsvQBSavAS2Kn3l9lULtHoLxYiJe7Jiin0lY8k0RM4MqaFh+z26 442c/JN8WSLjNpDrcLJ0R3oWt40K5cvC3aXkngD4CpyJe8cwjvy0pZoM5f/EtTuH WaEHMpjr7GMZjN7ehy+C+axFeiPJsdTZH5XJ73cKkD7aYwbzzmY2zpHanzwSYnHj ZsCNx/HqZi3ngW4AqBuOsmioABAUYw== =dFaa -----END PGP SIGNATURE-----