Re: [PATCH 04/17] block: remove the q argument from blk_rq_map_kern
Hannes Reinecke <[email protected]>
| Newsgroups | org.kernel.vger.linux-bcache,dev.linux.lists.dm-devel,dev.linux.lists.gfs2,org.kernel.vger.linux-block,org.kernel.vger.linux-btrfs,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-pm,org.kernel.vger.linux-xfs |
|---|---|
| Message-ID | <[email protected]> |
On 4/22/25 16:26, Christoph Hellwig wrote: > Remove the q argument from blk_rq_map_kern and the internal helpers > called by it as the queue can trivially be derived from the request. > > Signed-off-by: Christoph Hellwig <[email protected]> > --- > block/blk-map.c | 24 ++++++++++-------------- > drivers/block/pktcdvd.c | 2 +- > drivers/block/ublk_drv.c | 3 +-- > drivers/block/virtio_blk.c | 4 ++-- > drivers/nvme/host/core.c | 2 +- > drivers/scsi/scsi_ioctl.c | 2 +- > drivers/scsi/scsi_lib.c | 3 +-- > include/linux/blk-mq.h | 4 ++-- > 8 files changed, 19 insertions(+), 25 deletions(-) > Good cleanup. I always wondered why we need to have it. Reviewed-by: Hannes Reinecke <[email protected]> Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect [email protected] +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich