[PATCH v2] bcache: Use vmalloc_array() to improve code
tanze <[email protected]> Thu, 23 Oct 2025 10:26:42 +0800
| Newsgroups | org.kernel.vger.linux-bcache,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
Remove array_size() calls and replace vmalloc(), due to vmalloc_array() being optimized better, using fewer instructions, and handling overflow more concisely. Signed-off-by: tanze <[email protected]> --- Hi, Coly Li. Thank you for your suggestions. I have made revisions according to your requirements. Do you have any further suggestions? --- Changes in v2: - Fix coding style and formatting issues. --- drivers/md/bcache/sysfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/md/bcache/sysfs.c b/drivers/md/bcache/sysfs.c index 826b14cae4e5..1ecd2cb3d302 100644 --- a/drivers/md/bcache/sysfs.c +++ b/drivers/md/bcache/sysfs.c @@ -1061,8 +1061,8 @@ SHOW(__bch_cache) uint16_t q[31], *p, *cached; ssize_t ret; - cached = p = vmalloc(array_size(sizeof(uint16_t), - ca->sb.nbuckets)); + cached = p = vmalloc_array(ca->sb.nbuckets, sizeof(uint16_t)); + if (!p) return -ENOMEM; -- 2.25.1