Re: [PATCH v5 2/3] block: prohibit calls to bio_chain_endio

Christoph Hellwig <[email protected]> 于2025年12月4日周四 17:40写道：
>
> On Thu, Dec 04, 2025 at 10:47:47AM +0800, zhangshida wrote:
> > From: Shida Zhang <[email protected]>
> >
> > Now that all potential callers of bio_chain_endio have been
> > eliminated, completely prohibit any future calls to this function.
> >
> > Suggested-by: Ming Lei <[email protected]>
> > Suggested-by: Andreas Gruenbacher <[email protected]>
> > Suggested-by: Christoph Hellwig <[email protected]>
> > Signed-off-by: Shida Zhang <[email protected]>
> > ---
> >  block/bio.c | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/block/bio.c b/block/bio.c
> > index b3a79285c27..cfb751dfcf5 100644
> > --- a/block/bio.c
> > +++ b/block/bio.c
> > @@ -320,9 +320,13 @@ static struct bio *__bio_chain_endio(struct bio *bio)
> >       return parent;
> >  }
> >
> > +/**
> > + * This function should only be used as a flag and must never be called.
> > + * If execution reaches here, it indicates a serious programming error.
> > + */
>
> This is not a kerneldoc comment and thus should not use /** to start
> the comment, otherwise the kerneldoc script will complain about
> missing kernel doc elelemts.
>

Thanks for catching that. I'll fix the comment format in the next revision.

Thanks,
Shida


> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <[email protected]>