Re: [PATCH] Revert "bcache: fix improper use of bi_end_io"

On Tue, Jan 13, 2026 at 07:00:03AM -0800, Christoph Hellwig wrote:
> On Tue, Jan 13, 2026 at 04:27:19AM -0500, Kent Overstreet wrote:
> > It's not being a dick to tell someone they need to slow down and be more
> > careful when they're doing something broken and arguing over the revert.
> 
> Yes, you are.  I did not actually do anything here but point out that
> bcache is broken.

There've been no bug reports, people are using the code and it works.
You keep claiming breakage, and I asked you to explain what you thought
was wrong with the bare bi_end_io call - but you still haven't, and I'm
not buying it because I know what the code in bio_endio() does - I wrote
some of it, after all, and none of it expects to be called twice on the
same bio.

You're making changes in code you didn't write, bypassing the
maintainers to get it in, without providing any real justification -
that's reckless. And you have a habit of calling things "broken"
without a good reason, so please cut that out.

If, as you claim, calling a bare bi_end_io function in this context is a
problem, you better be able to explain why.