Re: [PATCH] Revert "bcache: fix improper use of bi_end_io"

On Wed, Jan 14, 2026 at 12:22:56AM +0800, Coly Li wrote:
> On Tue, Jan 13, 2026 at 12:07:54AM +0800, Christoph Hellwig wrote:
> > On Tue, Jan 13, 2026 at 02:09:39PM +0800, [email protected] wrote:
> > > From: Coly Li <[email protected]>
> > > 
> > > This reverts commit 53280e398471f0bddbb17b798a63d41264651325.
> > > 
> > > The above commit tries to address the race in bio chain handling,
> > > but it seems in detached_dev_end_io() simply using bio_endio() to
> > > replace bio->bi_end_io() may introduce potential regression.
> > > 
> > > This patch revert the commit, let's wait for better fix from Shida.
> > 
> > That's a pretty vague commit message for reverting a clear API
> > violation that has caused trouble.  What is the story here?
> > 
> 
> The discussion happens in stable mailing list. Also I admitted my fault.
> Though I didn't ack commit 53280e398471 ("bcache: fix improper use of
> bi_end_io"), I read it and overlooked the bio_endio() duplicated entry
> issue.

Please try to document the rationale in the commit logs, the current
one was extremely vague.