Re: [PATCH] bcache: fix uninitialized closure object

"Coly Li" <[email protected]> Tue, 7 Apr 2026 17:28:38 +0800
Newsgroups org.kernel.vger.linux-bcache
Message-ID <[email protected]>
> 2026=E5=B9=B44=E6=9C=883=E6=97=A5 19:11=EF=BC=8CJens Axboe <axboe@kernel.=
dk> =E5=86=99=E9=81=93=EF=BC=9A
>=20
> On 4/2/26 10:21 PM, [email protected] wrote:
>> From: Mingzhe Zou <[email protected]>
>>=20
>> In the previous patch ("bcache: fix cached_dev.sb_bio use-after-free and
>> crash"), we adopted a simple modification suggestion from AI to fix the
>> use-after-free.
>>=20
>> But in actual testing, we found an extreme case where the device is
>> stopped before calling bch_write_bdev_super().
>>=20
>> At this point, struct closure sb_write has not been initialized yet.
>> For this patch, we ensure that sb_bio has been completed via
>> sb_write_mutex.
>=20
> Presumably this should have a:
>=20
> Fixes: fec114a98b87 ("bcache: fix cached_dev.sb_bio use-after-free and cr=
ash")
>=20
> but for some reason it does not. I'll add it.

I did it on purpose. Because this patch is in Linux-stable and not in mainl=
ine,
I am not sure whether it is proper to reference the linux-block tree commit=
 id.

This is why the patch title is mentioned in commit log, but commit id skipp=
ed.

Thanks for adding it.

Coly Li