Re: [PATCH v14 4/4] rust: support large alignments in allocations

Vitaly Wool <[email protected]> Thu, 31 Jul 2025 11:02:45 +0200

Newsgroups	org.kernel.vger.linux-bcachefs,org.kernel.vger.bpf,org.kernel.vger.linux-kernel,org.kernel.vger.rust-for-linux,org.kvack.linux-mm
Message-ID	<[email protected]>


> On Jul 30, 2025, at 10:18 PM, Danilo Krummrich <[email protected]> wrote:
> 
> On Wed Jul 30, 2025 at 9:21 PM CEST, Vitaly Wool wrote:
>> diff --git a/rust/kernel/alloc/allocator_test.rs b/rust/kernel/alloc/allocator_test.rs
>> index d19c06ef0498..17b27c6e9e37 100644
>> --- a/rust/kernel/alloc/allocator_test.rs
>> +++ b/rust/kernel/alloc/allocator_test.rs
>> @@ -40,6 +40,7 @@ unsafe fn realloc(
>>         layout: Layout,
>>         old_layout: Layout,
>>         flags: Flags,
>> +        nid: NumaNode,
>>     ) -> Result<NonNull<[u8]>, AllocError> {
>>         let src = match ptr {
>>             Some(src) => {
> 
> I think this hunk should be on patch 3.
> 
> Also, don't you see a warning when running the rusttest target? I think it has
> to be _nid, given that the argument is unused.

Indeed, thanks. I’ll respin the patchset shortly.

~Vitaly