Re: [koverstreet-bcachefs:master 219/231] fs/bcachefs/dirent.c:765:1: warning: the frame size of 1344 bytes is larger than 1280 bytes

Kent Overstreet <[email protected]>
Newsgroups org.kernel.vger.linux-bcachefs,dev.linux.lists.oe-kbuild-all
Message-ID <bs6zfkf7si336ked6hfnj27o25oioaiy24vgz5m7izdbc7u5g2@nkzzojhbxx6o>
On Thu, Jul 31, 2025 at 10:46:17PM +0800, kernel test robot wrote:
> tree:   https://github.com/koverstreet/bcachefs master
> head:   53def8896bdc4b3f7a15affd6f867cbc6f64dc14
> commit: 8cf424e23e76826583cef06af21ada70f22ff85f [219/231] bcachefs: CLASS(btree_iter)
> config: arm-allmodconfig (https://download.01.org/0day-ci/archive/20250731/[email protected]/config)
> compiler: arm-linux-gnueabi-gcc (GCC) 15.1.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250731/[email protected]/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <[email protected]>
> | Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> 
> All warnings (new ones prefixed by >>):
> 
>    fs/bcachefs/dirent.c: In function 'bch2_fsck_remove_dirent':
> >> fs/bcachefs/dirent.c:765:1: warning: the frame size of 1344 bytes is larger than 1280 bytes [-Wframe-larger-than=]
>      765 | }
>          | ^
> 
> 
> vim +765 fs/bcachefs/dirent.c
> 
> 758ea4ff812b4d Kent Overstreet 2025-03-20  743  
> 758ea4ff812b4d Kent Overstreet 2025-03-20  744  int bch2_fsck_remove_dirent(struct btree_trans *trans, struct bpos pos)
> 758ea4ff812b4d Kent Overstreet 2025-03-20  745  {
> 758ea4ff812b4d Kent Overstreet 2025-03-20  746  	struct bch_fs *c = trans->c;
> 758ea4ff812b4d Kent Overstreet 2025-03-20  747  	struct bch_inode_unpacked dir_inode;
> 758ea4ff812b4d Kent Overstreet 2025-03-20  748  	struct bch_hash_info dir_hash_info;
> 758ea4ff812b4d Kent Overstreet 2025-03-20  749  
> 8cf424e23e7682 Kent Overstreet 2025-07-30  750  	int ret = lookup_first_inode(trans, pos.inode, &dir_inode);
> 758ea4ff812b4d Kent Overstreet 2025-03-20  751  	if (ret)
> 758ea4ff812b4d Kent Overstreet 2025-03-20  752  		goto err;
> 758ea4ff812b4d Kent Overstreet 2025-03-20  753  
> 758ea4ff812b4d Kent Overstreet 2025-03-20  754  	dir_hash_info = bch2_hash_info_init(c, &dir_inode);
> 758ea4ff812b4d Kent Overstreet 2025-03-20  755  
> 8cf424e23e7682 Kent Overstreet 2025-07-30  756  	CLASS(btree_iter, iter)(trans, BTREE_ID_dirents, pos, BTREE_ITER_intent);
> 758ea4ff812b4d Kent Overstreet 2025-03-20  757  
> 25201eae7abed7 Kent Overstreet 2025-07-30  758  	ret =   bch2_btree_iter_traverse(&iter) ?:
> 758ea4ff812b4d Kent Overstreet 2025-03-20  759  		bch2_hash_delete_at(trans, bch2_dirent_hash_desc,
> 758ea4ff812b4d Kent Overstreet 2025-03-20  760  				    &dir_hash_info, &iter,
> 758ea4ff812b4d Kent Overstreet 2025-03-20  761  				    BTREE_UPDATE_internal_snapshot_node);
> 758ea4ff812b4d Kent Overstreet 2025-03-20  762  err:
> 758ea4ff812b4d Kent Overstreet 2025-03-20  763  	bch_err_fn(c, ret);
> 758ea4ff812b4d Kent Overstreet 2025-03-20  764  	return ret;
> 758ea4ff812b4d Kent Overstreet 2025-03-20 @765  }
> 
> :::::: The code at line 765 was first introduced by commit
> :::::: 758ea4ff812b4dfd4cef6dba0eb4b0025a7b147e bcachefs: Move bch2_check_dirent_target() to namei.c
> 
> :::::: TO: Kent Overstreet <[email protected]>
> :::::: CC: Kent Overstreet <[email protected]>
> 
> -- 
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki

If someone wants to do some pa-holing (or show the idiot how), I've
never been able to figure out how get it to show the stack frame layout.

The variables in this function add up to ~300 bytes, I have no idea
where that's turning into 1344 bytes.
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.