Re: [PATCH] bcachefs: Simplify kzalloc usage
Kent Overstreet <[email protected]>
| Newsgroups | org.kernel.vger.linux-bcachefs,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <hu5y7xoxtx6sqk6vegszx3jgngmu2pvqbscmk6hok3du6qrkr7@26zo2k73o5b2> |
On Thu, Jul 31, 2025 at 10:00:31PM +0200, Markus Elfring wrote: > >>> Use the shorter variants will improves further maintainability. > >>> Convenient for subsequent code updates or refactoring. > >> > >> Please improve such a change description. > >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.16#n45 > >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.16#n941 > > > > The commit message is reasonable, it communicates the intent. > > * I would wonder about the relevance of a shorter item here. > > * Would you like to avoid wording weaknesses? > > > Another example for previous contributions: > https://lore.kernel.org/all/?q=%22Improve%20size%20determinations%22 > > > > I haven't decided if I want to apply it; the dereference approach is > > better in principle but it's very far off into the weeds of "things that > > will never, ever cause an actual problem". > > Have you got development views which might be in contradiction > to the preferred Linux coding style? Marcus, I believe you've been warned in other subsystems, by other maintainers - you need to cut this out. I decide what's acceptable for patches to bcachefs, not you :)