Re: [PATCH blktests 1/2] loop/009: only skip on a genuinely unrecognized --ping option

Shin'ichiro Kawasaki <[email protected]>
Newsgroups org.kernel.vger.linux-block
Message-ID <amK1dRmJSiaLbPvu@shinhome>
On Jul 21, 2026 / 18:04, Sebastian Chlad wrote:
> udevadm control --ping can also fail when udevd is busy or unresponsive
> not only when the option is genuinely unsupported. Treating any failure
> as "unsupported" risked masking a real udevd problem behind a
> misleading skip reason instead of letting the test run and report it.
> 
> Signed-off-by: Sebastian Chlad <[email protected]>
> ---
>  tests/loop/009 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/loop/009 b/tests/loop/009
> index d3c7991..944f53b 100755
> --- a/tests/loop/009
> +++ b/tests/loop/009
> @@ -11,7 +11,7 @@ DESCRIPTION="check that LOOP_CONFIGURE sends uevents for partitions"
>  QUICK=1
>  
>  requires() {
> -	if ! udevadm control --ping >& /dev/null; then
> +	if ! udevadm control --help 2>&1 | grep -q -- '--ping'; then

I applied this patch. FYI, I took the liberty to replace the short option -q
above with the long option --quiet. Thanks!
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.