Re: [PATCH] ublk: configure io buffer before taking uring_cmd

Yang Xiuwei <[email protected]> Sun, 26 Jul 2026 09:23:43 +0800

Newsgroups	org.kernel.vger.linux-block
Message-ID	<[email protected]>

Hi Caleb,

On Sat, Jul 25, 2026 at 12:18:55PM -0700, Caleb Sander Mateos wrote:
> I'm not sure this ordering works either. __ublk_fetch() is responsible
> for checking that the I/O is in a valid state to fetch (device not yet
> started, I/O not yet fetched). It wouldn't be safe to overwrite
> io->buf before this check. Probably it would make sense to perform the
> sqe->addr validation before calling __ublk_fetch() and then make
> ublk_config_io_buf() infallible.

Agreed, will fix that in v2.

Thanks,
Yang Xiuwei