Re: [PATCH v1] block/mq-deadline: hold elevator_lock in debugfs next_rq show

Xixin Liu <[email protected]> Mon, 27 Jul 2026 18:25:00 +0800
Newsgroups org.kernel.vger.linux-block,org.kernel.vger.linux-kernel
Message-ID <reply-mq-deadline-next-rq-af98cabf-followup.20260727.182500.liuxixin@kylinos.cn>
Hi Bart,

To add to my previous reply:

This part needs dd->lock, for example:

	per_prio = &dd->per_prio[prio];
	rq = deadline_from_pos(...);

because both the per-priority state selection and the subsequent
deadline_from_pos() walk access mq-deadline internal state that is
protected by dd->lock.

Separately, q->elevator_lock is still needed earlier to stabilize
q->elevator and obtain e->elevator_data safely during an elevator
switch.

Thanks,
Xixin