[PATCH] ublk: remove WARN_ON_ONCE() in ublk_unmap_io()
Caleb Sander Mateos <[email protected]> Mon, 27 Jul 2026 10:24:50 -0600
| Newsgroups | org.kernel.vger.linux-block,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
io->res is set from struct ublksrv_io_cmd's result field, which is controlled by the ublk server process, without any validation. It's thus possible for userspace to trigger the io->res > rq_bytes warning. ublk_copy_user_pages() already limits the copy length to the request data length, so drop the warning. Signed-off-by: Caleb Sander Mateos <[email protected]> --- drivers/block/ublk_drv.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c index 4ca6ec738c93..4f30644756df 100644 --- a/drivers/block/ublk_drv.c +++ b/drivers/block/ublk_drv.c @@ -1492,12 +1492,10 @@ static unsigned int ublk_unmap_io(bool need_map, if (ublk_need_unmap_req(req)) { struct iov_iter iter; const int dir = ITER_SOURCE; - WARN_ON_ONCE(io->res > rq_bytes); - import_ubuf(dir, u64_to_user_ptr(io->buf.addr), io->res, &iter); return ublk_copy_user_pages(req, 0, &iter, dir); } return rq_bytes; } -- 2.54.0