Re: [PATCH 3/6] ublk: split request validation from io_desc init

Ming Lei <[email protected]> Thu, 30 Jul 2026 09:37:50 -0500
Newsgroups org.kernel.vger.linux-block,org.kernel.vger.linux-kernel
Message-ID <amthvuMO8t9UHIv5@fedora-laptop>
On Tue, Jul 28, 2026 at 07:29:48PM -0600, Caleb Sander Mateos wrote:
> In preparation for moving the struct ublksrv_io_desc initialization from
> the thread submitting ublk requests to the daemon thread receiving them,
> split the fallible part of ublk_setup_iod{,_zoned}() into new helper
> ublk_validate_req{,_zoned}(). Only ublk_setup_iod{,_zoned}() accesses
> the io_desc and cannot error out.
> 
> Return a bool value from ublk_validate_req{,_zoned}() as the existing
> error code ublk_setup_iod{,_zoned}() returns is only checked against
> BLK_STS_OK.
> 
> Signed-off-by: Caleb Sander Mateos <[email protected]>

Reviewed-by: Ming Lei <[email protected]>

Thanks, 
Ming