Re: [PATCH v3 01/13] block: remove disk_free_zone_resources()

On Tue, Aug 11, 2026 at 07:58:40PM +0900, Damien Le Moal wrote:
> In the rare event when revalidating the zones of a zoned block device
> fails, the device capacity will be dropped to 0. In such case, the zoned
> block device will either be rescanned and restored or dropped entirely and
> its gendisk destroyed. So calling disk_free_zone_resources() from

is destroyed

> blk_revalidate_disk_zones() in case of error does not make much sense. We

an error

> can keep the zone resources in case the device is rescanned and restored
> or simply free all resources in disk_release_zone_resources() when the
> gendick is destroyed.

gendisk

> 
> Remove the call to disk_free_zone_resources() from
> blk_revalidate_disk_zones() and squash disk_free_zone_resources() inside
> disk_release_zone_resources(). With this change, the conditional creation
> of the zone write plugs work queue is not necessary anymore as the
> workqueue will keep existing together with all other resources until the
> disk is released. This simplifies disk_alloc_zone_resources().

Other than that:
Reviewed-by: Johannes Thumshirn <[email protected]>