Re: [PATCH v3 11/13] block: allow read-only and offline conventional zones

On 8/11/26 12:58 PM, Damien Le Moal wrote:
> With SCSI and ATA SMR HDDs, the storage element depopulation feature can
> change the condition of conventional zones to read-only (if a write head
> is depopulated) or to offline (if a read head is depopulated).
> However, the function blk_revalidate_zone_cond() currently does not allow
> these conditions for conventional zones, causing a zone revalidation
> failure.
> 
> Remove blk_revalidate_zone_cond() and move the zone condition checks for
> conventional zones to blk_revalidate_conv_zone(), allowing the regular
> BLK_ZONE_COND_NOT_WP condition as well as the BLK_ZONE_COND_OFFLINE and
> BLK_ZONE_COND_READONLY conditions to match the conditions that can be
> seen from a zoned device with depopulated storage elements.
> 
> The zone condition checks for sequential write required zones are moved
> to blk_revalidate_seq_zone() without any change to the conditions allowed.
> 
> Signed-off-by: Damien Le Moal <[email protected]>
> Reviewed-by: Bart Van Assche <[email protected]>
> ---
>   block/blk-zoned.c | 65 +++++++++++++++++++----------------------------
>   1 file changed, 26 insertions(+), 39 deletions(-)
> 
Reviewed-by: Hannes Reinecke <[email protected]>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
[email protected]                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich