Re: [PATCH v7 02/43] fscrypt: allow inline encryption for extent based encryption
Daniel Vacek <[email protected]>
| Newsgroups | org.kernel.vger.linux-block,org.kernel.vger.linux-btrfs,org.kernel.vger.linux-fscrypt,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <CAPjX3FfouCuSTTBYASnjRgvu+kR7mJtRsd2WZ7Lc9om+P8hK0g@mail.gmail.com> |
On Tue, 2 Jun 2026 at 00:49, Eric Biggers <[email protected]> wrote: > On Wed, May 13, 2026 at 10:52:36AM +0200, Daniel Vacek wrote: > > From: Josef Bacik <[email protected]> > > > > Instead of requiring -o inlinecrypt to enable inline encryption, allow > > having s_cop->has_per_extent_encryption to indicate that this file > > system supports inline encryption. > > > > Signed-off-by: Josef Bacik <[email protected]> > > Signed-off-by: Daniel Vacek <[email protected]> > > --- > > > > v5: https://lore.kernel.org/linux-btrfs/ba0289bf103653d5d98ef576756c9a2a66192865.1706116485.git.josef@toxicpanda.com/ > > * No changes since. > > There are multiple places that check SB_INLINECRYPT, and just one was > updated. Perhaps we should just require that if a filesystem sets > has_per_extent_encryption, then it also sets SB_INLINECRYPT > unconditionally? has_per_extent_encryption means the kernel fs implementation supports extent encryption, not that the mounted filesystem uses encryption. That said it would result in all btrfs mounts setting SB_INLINECRYPT. Is that what you meant? --nX > - Eric