Re: [PATCH] ublk: avoid teardown retry loop on xarray allocation failure
Jens Axboe <[email protected]>
| Newsgroups | org.kernel.vger.linux-block |
|---|---|
| Message-ID | <178683855340.1984298.11749917980913499206.b4-ty@b4> |
On Tue, 04 Aug 2026 20:57:36 +0800, Yao Sang wrote:
> __ublk_shmem_remove_ranges() removes matching maple tree ranges in
> batches, but first stores each range into a temporary xarray so that the
> pages can be unpinned after dropping the maple tree lock.
>
> That temporary xarray is filled under the maple tree lock with
> xa_store(..., GFP_ATOMIC). If the store fails before mas_erase(), the
> current range is left in the tree and the helper returns false. The
> outer ublk_shmem_remove_ranges() loop then immediately retries the same
> range. While the atomic allocation keeps failing, the teardown path has
> no forward progress.
>
> [...]
Applied, thanks!
[1/1] ublk: avoid teardown retry loop on xarray allocation failure
commit: 4fd66a7f829f3f38f92a79081f0f2688aed644f0
Best regards,
--
Jens Axboe