Re: [PATCH] block: save page offset gaps in cloned bio

Christoph Hellwig <[email protected]>
Newsgroups org.kernel.vger.linux-block
Message-ID <[email protected]>
On Wed, Aug 19, 2026 at 08:04:43AM -0600, Keith Busch wrote:
> > > The split remainder meanwhile can reset its gaps to 0
> > > since it advanced beyond it and will start accounting from there.
> > 
> > I don't really understand this part, though.  As in I don't even
> > understand what you mean here..
> 
> The accounting for the vector gaps happens at the same time we consider
> a bio for splitting. When we do split, the gap value applies only to the
> front bio because that's as far as been processed. The remaining split
> bio should reset its gap value to 0, and it will be recalculated when it
> continues through the split consideration.

Ḣ. but bio_split is used for a lot of different thing.  Then again the
bi_bvec_gap_bit is only used by the low-level blk-mq code, so it might
not matter.  But this for sure warrants a big fat comment explaining
the rationale for the clearing.
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.