Re: [PATCH blktests] nvme/070: add multipath command effects log lifetime test
Shin'ichiro Kawasaki <[email protected]>
| Newsgroups | org.kernel.vger.linux-block |
|---|---|
| Message-ID | <aoaLLOaNlLd-p3zg@shinhome> |
On Aug 20, 2026 / 08:55, Yao Sang wrote: > Hi Shin'ichiro, > > Thanks for the review. I agree with the other suggestions, but I have one > concern about dropping the KASAN requirement. > > The issue is reliably reproducible with KASAN enabled. Without KASAN, > however, the test may pass even on an affected kernel and fail to catch > the bug. Given this limitation, do you think it is still appropriate to > remove the _have_kernel_options KASAN check? I rethought about this point, and now I think the KASAN check is fine. Let's keep it. As I noted, there are pros and cons for the KASAN check: if the test case runs on kernels that disable KASAN, the KASAN check will decresase code coverage. Said that, now I agree wint your point: the KASAN check is straight forward and it clearly describes the condition to recreate the failure. Actually, the test case nvme/069 also has the KASAN check already. Let's keep the KASAN check for consistency.