Re: [PATCH BlueZ bluez] bap: fixed the return value of GIOFunc

On Wed, 2026-07-29 at 09:47 +0800, Yang Li via B4 Relay wrote:
> From: Yang Li <[email protected]>
> 
> The GIOFunc should return FALSE if the event source should be
> removed.
> 
> Fixes: 322c39a64 (bap: Start BIG sync after receiving BIGInfo)
> 
> Signed-off-by: Yang Li <[email protected]>

Looks good, thanks.

Although I would have still preferred G_SOURCE_REMOVE which makes it
clearer what it does.

> ---
>  profiles/audio/bap.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/profiles/audio/bap.c b/profiles/audio/bap.c
> index 473e4cfc2..ff8f58a12 100644
> --- a/profiles/audio/bap.c
> +++ b/profiles/audio/bap.c
> @@ -3683,7 +3683,6 @@ static gboolean iso_do_big_sync(GIOChannel *io,
> GIOCondition cond,
>  			BT_IO_OPT_INVALID)) {
>  		error("bt_io_set: %s", err->message);
>  		g_error_free(err);
> -		return FALSE;
>  	}
>  
>  	if (!bt_io_bcast_accept(io,
> @@ -3694,10 +3693,9 @@ static gboolean iso_do_big_sync(GIOChannel
> *io, GIOCondition cond,
>  			iso_bc_addr.bc_bis, BT_IO_OPT_INVALID)) {
>  		error("bt_io_bcast_accept: %s", err->message);
>  		g_error_free(err);
> -		return FALSE;
>  	}
>  
> -	return TRUE;
> +	return FALSE;
>  }
>  
>  static void long_pa_sync_confirm_cb(GIOChannel *io, void *user_data)
> 
> ---
> base-commit: 729f96089cf66831d911385623ca932e0c245913
> change-id: 20260729-fix_iofunc-e62cecc52b8e
> 
> Best regards,