Re: [BlueZ, v2] unit: Add test for sdp_xml_parse_record()

On Wed, 2026-08-05 at 12:37 -0400, Luiz Augusto von Dentz wrote:
> Hi Bastien,
> 
> On Wed, Aug 5, 2026 at 11:07 AM Bastien Nocera <[email protected]>
> wrote:
> > 
> > This adds 2 example XML files from other repositories, under a fair
> > use
> > license exception.
> > ---
> > Changes since v1:
> > - Added an "expected result" field, so expected failures can also
> > pass
> >   tests.
> > 
> >  Makefile.am                               |  10 ++
> >  unit/sdp-xml/Bluetooth_HID-sdp_record.xml | 123
> > ++++++++++++++++++++++
> >  unit/sdp-xml/qt-SerialPortSDPRecord.xml   |  57 ++++++++++
> >  unit/test-sdp-xml.c                       |  81 ++++++++++++++
> >  4 files changed, 271 insertions(+)
> >  create mode 100644 unit/sdp-xml/Bluetooth_HID-sdp_record.xml
> >  create mode 100644 unit/sdp-xml/qt-SerialPortSDPRecord.xml
> >  create mode 100644 unit/test-sdp-xml.c
> 
> Why no reuse test-sdp?

Because I did not want to add XML parsing tests to something that
didn't link against it, and separate test binaries can run in parallel
(at least they can in meson), making running loads of small tests
faster than running larger tests.

Note that this patch is just the scaffolding for many other tests I
have locally, so let me know quickly if folding this code into
unit/sdp-xml.c is a requirement to getting it merged.

Cheers