Re: [BlueZ, v3 2/5] unit: Remove left-over test-avrcp Android test

On Thu, 2026-08-06 at 10:14 -0400, Luiz Augusto von Dentz wrote:
> Hi Bastien,
> 
> On Thu, Aug 6, 2026 at 9:29 AM Bastien Nocera <[email protected]>
> wrote:
> > 
> > This test was supposed to exercise the avrcp-lib from the Android
> > backend, but that backend was removed, and the library moved into
> > the unit/ directory.
> > 
> > The tests provide 0% coverage towards profiles/audio so they're
> > just
> > dead code we should remove.
> > ---
> >  Makefile.am       |    9 -
> >  unit/avrcp-lib.c  | 3604 -----------------------------------------
> > ----
> >  unit/avrcp-lib.h  |  343 -----
> >  unit/test-avrcp.c | 2084 --------------------------
> >  4 files changed, 6040 deletions(-)
> >  delete mode 100644 unit/avrcp-lib.c
> >  delete mode 100644 unit/avrcp-lib.h
> >  delete mode 100644 unit/test-avrcp.c
> > 
> > diff --git a/Makefile.am b/Makefile.am
> > index 19c468d3a504..f4f638323c79 100644
> > --- a/Makefile.am
> > +++ b/Makefile.am
> > @@ -651,15 +651,6 @@ unit_test_avctp_SOURCES = unit/test-avctp.c \
> >                                 unit/avctp.c unit/avctp.h
> >  unit_test_avctp_LDADD = src/libshared-glib.la $(GLIB_LIBS)
> > 
> > -unit_tests += unit/test-avrcp
> > -
> > -unit_test_avrcp_SOURCES = unit/test-avrcp.c \
> > -                               src/log.h src/log.c \
> > -                               unit/avctp.c unit/avctp.h \
> > -                               unit/avrcp-lib.c unit/avrcp-lib.h
> > -unit_test_avrcp_LDADD = lib/libbluetooth-internal.la \
> > -                               src/libshared-glib.la $(GLIB_LIBS)
> 
> The tests are valid, what isn't valid is that it doesn't test the
> right implementation, I understand this is a much bigger work though.

I'm pretty certain that reviving them is a complete rewrite, and right
now, it just takes compile and testing time all for nothing.

If somebody wants to revive those tests, they're a "git revert" away.