Re: [PATCH BlueZ v2 0/5] Add CS distance provider implementation
Luiz Augusto von Dentz <[email protected]>
| Newsgroups | org.kernel.vger.linux-bluetooth |
|---|---|
| Message-ID | <CABBYNZK76sQpZ1Ssh1nc0CnHXnY72A3Z=J75pOkkh7GMqUWh6w@mail.gmail.com> |
Hi Naga, On Wed, Aug 12, 2026 at 6:03 AM Naga Bhavani Akella <[email protected]> wrote: > > From: Naga Bhavani Akella <[email protected]> > > This series documents and implements the D-Bus API that lets an > external ranging daemon compute Channel Sounding distance estimates > from the raw procedure data BlueZ reports, and feed them back for > reflection on the device's Channel Sounding interface > > Patch 1 documents CSDistance1, the BlueZ-owned interface > that reflects the provider's DistanceMeters estimate for consumption > by desktop clients. > > Patch 2 documents CSDistanceProvider, the interface the > registered provider implements to expose per-device distance > estimates. > > Patch 3 documents CSDistanceProviderManager, which a > ranging daemon uses to register/unregister itself as a distance > provider. > > Patch 4 and 5 implements CS Distance Provider and Provider Manager > interfaces I would prefer to name it after the profile as just org.bluez.Ranging*, it also doesn't hurt to document the relationship of each interface with diagrams to ilustrate how to register and the notify e.g. Ranging.PropertiesChanged("Distance", value). Regarding the unit of measurement, do any specifications actually require it to be a double and in meters, or was this picked based on some reference implementation? We could perhaps simplify it to use centimeters, or even millimeters, in a uint32. That would give plenty of range without requiring floating-point math. > > Naga Bhavani Akella (5): > doc: Add org.bluez.CSDistance1 documentation > doc: Add org.bluez.CSDistanceProvider documentation > doc: Add org.bluez.CSDistanceProviderManager documentation > rap: Add CS Distance provider D-Bus API > client: Add CS distance display support to bluetoothctl > > Makefile.am | 16 +- > client/cs.c | 2 +- > client/cs.h | 1 + > client/main.c | 33 ++ > doc/org.bluez.CSDistance1.rst | 36 ++ > doc/org.bluez.CSDistanceProvider.rst | 32 ++ > doc/org.bluez.CSDistanceProviderManager.rst | 53 ++ > src/adapter.c | 12 + > src/cs_distance.c | 578 ++++++++++++++++++++ > src/cs_distance.h | 23 + This becomes src/ranging.{c, h} > 10 files changed, 783 insertions(+), 3 deletions(-) > create mode 100644 doc/org.bluez.CSDistance1.rst > create mode 100644 doc/org.bluez.CSDistanceProvider.rst > create mode 100644 doc/org.bluez.CSDistanceProviderManager.rst > create mode 100644 src/cs_distance.c > create mode 100644 src/cs_distance.h > > -- > -- Luiz Augusto von Dentz