Re: [PATCH v3] Bluetooth: pm: use SIMPLE_DEV_OPS for pm struct

Hi Li,

On Wed, Aug 19, 2026 at 2:41 AM Li Jun <[email protected]> wrote:
>
> use SIMPLE_DEV_PM_OPS for btmrvl_sdio_pm_ops,and add the value of
> .freeze .thaw .poweroff .restore.if these address are null, may cause
> error in s4.
>
> Signed-off-by: Li Jun <[email protected]>
> ---
>  drivers/bluetooth/btmrvl_sdio.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/bluetooth/btmrvl_sdio.c b/drivers/bluetooth/btmrvl_sdio.c
> index b91fc63bc9fe..197237e78a3c 100644
> --- a/drivers/bluetooth/btmrvl_sdio.c
> +++ b/drivers/bluetooth/btmrvl_sdio.c
> @@ -1726,10 +1726,7 @@ static int btmrvl_sdio_resume(struct device *dev)
>         return 0;
>  }
>
> -static const struct dev_pm_ops btmrvl_sdio_pm_ops = {
> -       .suspend        = btmrvl_sdio_suspend,
> -       .resume         = btmrvl_sdio_resume,
> -};
> +SIMPLE_DEV_PM_OPS(btmrvl_sdio_pm_ops, btmrvl_sdio_suspend, btmrvl_sdio_resume);

It looks like we are missing a static in front:

https://sashiko.dev/#/patchset/20260819064115.2449018-1-lijun01%40kylinos.cn

>  static struct sdio_driver bt_mrvl_sdio = {
>         .name           = "btmrvl_sdio",
> --
> 2.25.1
>


-- 
Luiz Augusto von Dentz