Re: [PATCH 3/3] blkparse: Fix up the sector and length of split completions

Andreas Gruenbacher <[email protected]>
Newsgroups org.kernel.vger.linux-btrace
Message-ID <CAHc6FU5SNrfyV_WCz3Hr1MwwbhN6KL8XzjGYibXtyynTcmJ4yA@mail.gmail.com>
On Mon, Apr 6, 2020 at 4:09 PM Andreas Gruenbacher <[email protected]> wrote:
> When a split io completes, the sector and length of the completion refer to the
> last split of the original request.  This makes reading the blkparse output
> difficult, so fix up the sector and length to match the original request when
> we can (that is, when --track-ios is enabled).

I've noticed that split requests also cause the queued vs. completed
statistics at the end of a trace to be completely off, so the same
fix-up logic is needed there as well.

Also, the code currently assumes that after request splitting, the
only event that will follow is the completion of the request. I hope
that assumption holds.

Any thoughts?

Thanks,
Andreas
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.