Re: [PATCH] fix hang when BLKTRACESETUP fails and "-o -" is used
Jens Axboe <[email protected]>
| Newsgroups | org.kernel.vger.linux-btrace |
|---|---|
| Message-ID | <[email protected]> |
On Wed, 05 Jun 2024 23:07:27 -0500, Eric Sandeen wrote:
> # blktrace -o - /dev/sda /dev/sdb /dev/sdc
>
> has to be SIGKILLed if BLKTRACESETUP fails for any or all of the devices
> listed. (I simulated this by just catching one of the devices in
> setup_buts(), skipping the ioctl, and doing ret++).
>
> This seems to be because with "-o -" on the command line, use_tracer_devpaths()
> sees piped_output set, so we call process_trace_bufs which ends up waiting on
> (!done) and "done" is never set. i.e.
>
> [...]
Applied, thanks!
[1/1] fix hang when BLKTRACESETUP fails and "-o -" is used
commit: 1836be5d99c9362f1e2b39206c95270f19cb7faa
Best regards,
--
Jens Axboe