Re: [PATCH 02/21] add definitions for BLKTRACESETUP2

On 9/9/25 04:07, Johannes Thumshirn wrote:
> Signed-off-by: Johannes Thumshirn <[email protected]>
> ---
>   blktrace_api.h | 15 +++++++++++++++
>   1 file changed, 15 insertions(+)
>
> diff --git a/blktrace_api.h b/blktrace_api.h
> index 172b4c2..9f435a5 100644
> --- a/blktrace_api.h
> +++ b/blktrace_api.h
> @@ -139,9 +139,24 @@ struct blk_user_trace_setup {
>   	__u32 pid;
>   };
>   
> +/*
> + * User setup structure passed with BLKTRACESETUP2
> + */
> +struct blk_user_trace_setup2 {
> +	char name[32];			/* output */
> +	__u64 act_mask;			/* input */
> +	__u32 buf_size;			/* input */
> +	__u32 buf_nr;			/* input */
> +	__u64 start_lba;
> +	__u64 end_lba;
> +	__u32 pid;
> +	__u32 reserved;			/* for futute use */
> +};
> +
>   #define BLKTRACESETUP _IOWR(0x12,115,struct blk_user_trace_setup)
>   #define BLKTRACESTART _IO(0x12,116)
>   #define BLKTRACESTOP _IO(0x12,117)
>   #define BLKTRACETEARDOWN _IO(0x12,118)
> +#define BLKTRACESETUP2 _IOWR(0x12, 142, struct blk_user_trace_setup2)
>   
>   #endif

This definitely needs a commit log explaining why you need setup2 struct and
what kind of problem it is solving.

-ck