Re: [PATCH 01/16] blktrace: split do_blk_trace_setup into two functions

Christoph Hellwig <[email protected]> Fri, 19 Sep 2025 17:06:12 +0200

Newsgroups	org.kernel.vger.linux-btrace,org.kernel.vger.linux-block,org.kernel.vger.linux-kernel,org.kernel.vger.linux-trace-kernel
Message-ID	<[email protected]>

On Tue, Sep 09, 2025 at 01:05:56PM +0200, Johannes Thumshirn wrote:
> Split do_blk_trace_setup into two functions, this is done to prepare for
> an incoming new BLKTRACESETUP2 ioctl(2) which can receive extended
> parameters form user-space.

This not just splits the function, but also moves some of the logic
to the caller.  Which looks fine, but should be documented here or
even better split out into a separate patch.