Re: [PATCH v2 06/15] blktrace: split do_blk_trace_setup into two functions

Christoph Hellwig <[email protected]> Fri, 3 Oct 2025 09:27:52 +0200
Newsgroups org.kernel.vger.linux-btrace,org.kernel.vger.linux-block,org.kernel.vger.linux-kernel,org.kernel.vger.linux-trace-kernel
Message-ID <[email protected]>
On Thu, Sep 25, 2025 at 05:02:22PM +0200, Johannes Thumshirn wrote:
> Split do_blk_trace_setup into two functions, this is done to prepare for
> an incoming new BLKTRACESETUP2 ioctl(2) which can receive extended
> parameters form user-space.
> 
> Also move the size verification logic to the callers.

Can you add a why for that move?

Otherwise this looks sane.