Re: [PATCH 02/11] btt: natively parse blk_io_trace2

Damien Le Moal <[email protected]> Thu, 16 Jul 2026 20:47:50 +0900
Newsgroups org.kernel.vger.linux-btrace,org.kernel.vger.linux-block
Organization Western Digital Research
Message-ID <[email protected]>
On 7/16/26 20:04, Johannes Thumshirn wrote:
> Natively parse 'struct blk_io_trace2' from a blktrace binary.
> 
> Detect the layout by parsing the input as both 'struct blk_io_trace' and

s/both/either ?

Otherwise this is unclear as one input cannot have both formats :)

> 'struct blk_io_trace2' and using whichever interprets the trace stream
> cleanly.
> 
> Signed-off-by: Johannes Thumshirn <[email protected]>

Other than the nit above, looks OK to me.

Reviewed-by: Damien Le Moal <[email protected]>

-- 
Damien Le Moal
Western Digital Research