Re: [PATCH v2 03/11] blktrace: add option to request a specific trace protocol version

Damien Le Moal <[email protected]> Mon, 20 Jul 2026 20:52:33 +0900
Newsgroups org.kernel.vger.linux-btrace,org.kernel.vger.linux-block
Organization Western Digital Research
Message-ID <[email protected]>
On 7/20/26 20:14, Johannes Thumshirn wrote:
> Add the '--trace-version=<1|2>' command line option to select the trace
> protocol version requested from the kernel. Requesting version 1 forces
> blktrace to use the old BLKTRACESETUP ioctl, while version 2 (the
> default) uses BLKTRACESETUP2.
> 
> Signed-off-by: Johannes Thumshirn <[email protected]>

Looks OK to me.

Reviewed-by: Damien Le Moal <[email protected]>


-- 
Damien Le Moal
Western Digital Research