Re: [PATCH 1/2] btrfs: add "rescue=usebackuproot" into forced read-only options

在 2026/7/3 12:03, Dongjiang Zhu 写道:
> 在 2026/7/3 7:40, Qu Wenruo 写道:
>> According to btrfs(5) man page, all rescue options should require an
>> read-only mount.
>>
>> But that read-only check is only introduced for newer rescue options,
>> not for the pre-existing "usebackuproot" one.
>>
>> Unify the behavior to match the document.
>> [...]
> 
> Hi Qu,
> 
> Just a small note from looking at this together with my CLEAR_CACHE patch.
> 
> If rescue=usebackuproot requires a read-only mount, my patch to set
> CLEAR_CACHE for it may no longer be needed.

Yes, this patchset is inspired by your patch.

> 
> Also, should rescue=all include usebackuproot too?

That's a good catch.

I'll add a patch to add that into the series.

Thanks,
Qu

> 
> Thanks,
> Dongjiang
>