Re: [PATCH v2 0/5] btrfs: some optimizations and cleanups for log syncing

On Wed, 2026-07-22 at 16:24 +0100, [email protected] wrote:
> From: Filipe Manana <[email protected]>
> 
> Some optimizations for log syncing, specially for non-sdd mounts, and
> some cleanups. Details in the changelogs of each patch.
> 
> V2: Removed two patches which sashiko found problematic, the benefits of
>     fixing them up versus the complexity required to fix them is not worth
>     it. Updated last patch to add the data_race() annotation in the trace
>     events.
> 
> Filipe Manana (5):
>   btrfs: stop sleeping for one jiffy in non-ssd mounts during log commit
>   btrfs: remove log batch counter use for fsync
>   btrfs: move condition for log commit wait into wait_log_commit()
>   btrfs: check for exit condition after waking in wait_log_commit()
>   btrfs: use simple booleans for log_commit field in struct btrfs_root
> 
>  fs/btrfs/ctree.h             |  6 +--
>  fs/btrfs/disk-io.c           |  3 --
>  fs/btrfs/file.c              |  4 --
>  fs/btrfs/transaction.c       |  8 +---
>  fs/btrfs/tree-log.c          | 85 ++++++++++++------------------------
>  include/trace/events/btrfs.h |  4 +-
>  6 files changed, 32 insertions(+), 78 deletions(-)

These all look like good cleanups, and the diffstat is nice!

Reviewed-by: Jeff Layton <[email protected]>