Re: [PATCH] btrfs: zoned: propagate do_zone_finish() error in btrfs_zone_finish_endio()
Johannes Thumshirn <[email protected]>
| Newsgroups | org.kernel.vger.linux-btrfs |
|---|---|
| Message-ID | <[email protected]> |
On 8/19/26 12:44 AM, Qu Wenruo wrote: > > > 在 2026/8/19 08:11, Qu Wenruo 写道: >> >> >> 在 2026/8/18 19:30, Johannes Thumshirn 写道: >>> btrfs_zone_finish_endio() ignored the return value of do_zone_finish() >>> and always returned 0, silently dropping a failed zone finish. >>> >>> Instead propagate any error from do_zone_finish() as the caller >>> btrfs_finish_ordered_io() already handles it. >>> >>> Signed-off-by: Johannes Thumshirn <[email protected]> >> >> Reviewed-by: Qu Wenruo <[email protected]> > > BTW, you may still want to check the sashiko review, which exposed an > pre-existing bug in the error handling path: > > https://sashiko.dev/#/patchset/20260818100037.1366563-1-johannes.thumshirn%40wdc.com Oh thanks, I would've missed this. From a quick glance it looks valid. I'll take care of it.