Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The flexcan driver fails to claim the newly added 'nxp,s32n79-flexcan' compatible string.
--
--- Patch [4]: [PATCH v6 4/6] dt-bindings: can: fsl,flexcan: add NXP S32N79 SoC support ---
commit 81a73119cf0179abcfa99d350e69491bfd8303b6
Author: Ciprian Marian Costea <[email protected]>
dt-bindings: can: fsl,flexcan: add NXP S32N79 SoC support
This commit adds the NXP S32N79 SoC compatible string and interrupt properties
to the FlexCAN device tree binding. On this platform, the IP uses separate
interrupt lines for mailboxes and bus errors.
> diff --git a/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml b/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
> index f81d56f7c12a5..d098a44c2b9c2 100644
> --- a/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
> +++ b/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
> @@ -26,6 +26,7 @@ properties:
> - fsl,ls1021ar2-flexcan
> - fsl,lx2160ar1-flexcan
> - nxp,s32g2-flexcan
> + - nxp,s32n79-flexcan
[Severity: Medium]
Does the flexcan driver need to be updated to claim this new compatible
string?
Because the binding does not provide a fallback compatible string, devices
using nxp,s32n79-flexcan will fail to probe unless flexcan_of_match in
drivers/net/can/flexcan/flexcan-core.c is also updated to include it. Is there
a companion patch planned to update the driver's match table?
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=4
lmpx.com only provides a reader for public news (NNTP) servers. It is not
affiliated with the servers or forums shown here and is not responsible for
the content of articles, which is written by their respective authors.