Re: [PATCH v13 09/11] can: bcm: fix stale rx/tx ops after device removal
Marc Kleine-Budde <[email protected]>
| Newsgroups | org.kernel.vger.linux-can,dev.linux.lists.sashiko-reviews |
|---|---|
| Message-ID | <[email protected]> |
On 14.07.2026 13:24:17, Oliver Hartkopp wrote: > On 14.07.26 12:44, [email protected] wrote: > > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: > > > > Pre-existing issues: > > - [High] Unprotected concurrent access to op->rx_stamp and op->rx_ifindex in bcm_rx_handler causes data races and torn 64-bit reads on 32-bit architectures. > > Fixed in patch 10 Pre-existing issues are not a shot stopper, _new_ issues for a patch series are...usually are. Hopefully upstream will accept that you fix issues in a later patch that sashiko claim to be introduced by a patch in the series. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung Nürnberg | Phone: +49-5121-206917-129 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
signature.asc
(application/pgp-signature, 228 B)
-----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQSl+MghEFFAdY3pYJLMOmT6rpmt0gUCalYgVAAKCRDMOmT6rpmt 0lNSAQD6GfIEjXJHGYZqTyGmtHCfVPtPBOYWpgzZ3UTec0b0EAEAtn3WIp88WKz7 1SrSo+BgBDk7E+Lg8fxp8rNhf+WyowE= =jZXP -----END PGP SIGNATURE-----