Re: [PATCH v13 09/11] can: bcm: fix stale rx/tx ops after device removal
Oliver Hartkopp <[email protected]>
| Newsgroups | org.kernel.vger.linux-can,dev.linux.lists.sashiko-reviews |
|---|---|
| Message-ID | <[email protected]> |
On 14.07.26 13:41, Marc Kleine-Budde wrote: > On 14.07.2026 13:24:17, Oliver Hartkopp wrote: >> On 14.07.26 12:44, [email protected] wrote: >>> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: >>> >>> Pre-existing issues: >>> - [High] Unprotected concurrent access to op->rx_stamp and op->rx_ifindex in bcm_rx_handler causes data races and torn 64-bit reads on 32-bit architectures. >> >> Fixed in patch 10 > > Pre-existing issues are not a shot stopper, _new_ issues for a patch > series are...usually are. > > Hopefully upstream will accept that you fix issues in a later patch that > sashiko claim to be introduced by a patch in the series. Is it? Patch 10 Fixes: ffd980f976e7 ("[CAN]: Add broadcast manager (bcm) protocol") not anything in patch 9. Best regards, Oliver