Re: [PATCH net] can: flexcan: Fix probing for m68k/coldfire

Uwe Kleine-König (The Capable Hub) <[email protected]> Mon, 20 Jul 2026 15:43:07 +0200

Newsgroups	org.kernel.vger.linux-can,org.kernel.vger.linux-kernel,org.kernel.vger.stable
Message-ID	<al4lxVud4_6NTZQG@monoceros>

Hello,

On Fri, Jul 03, 2026 at 06:53:16PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> On Thu, Jun 18, 2026 at 04:01:47PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> > When determining the device details was reworked in commit 5e6c3454b405
> > ("net: can: Use device_get_match_data()") there was no replacement for
> > the previous handling of non-of instantiated devices via the device's
> > id_entry which then results in a NULL pointer exception. The only
> > in-tree provider of such a device is arch/m68k/coldfire/device.c.
> > 
> > Given the id_table only contains a single entry just hardcode the result
> > of `platform_get_device_id(pdev)->driver_data` and drop the unused
> > assignment to .driver_data from the table.
> > 
> > While touching the id table, drop the unusual comma after the terminator
> > entry.
> > 
> > Fixes: 5e6c3454b405 ("net: can: Use device_get_match_data()")
> > Cc: [email protected]
> > Signed-off-by: Uwe Kleine-König (The Capable Hub) <[email protected]>
> 
> Given this fixes a crash (NULL pointer exception), it would be great to
> get this applied. The issue is already old (Sept 2023, v6.8-rc1), so
> there is probably no urge to get this in before 7.2, but getting it into
> next and then 7.3-rc1 would be good.

This still stands. Marc, do you have this patch still on your radar?

Best regards
Uwe

signature.asc (application/pgp-signature, 488 B)