Re: [PATCH 2/4] can: usb: ixxat_usb: add CL1 legacy protocol layer

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message claims that the adapter descriptor references open, close, start, and stop callbacks, but these are neither implemented nor present in the adapter structure.
--

--- Patch [2]: [PATCH 2/4] can: usb: ixxat_usb: add CL1 legacy protocol layer ---
commit cf00ec1244509265defabbebdffce90e57fb3e67
Author: Stéphane Grosjean <[email protected]>

can: usb: ixxat_usb: add CL1 legacy protocol layer

This commit implements the CL1 communication protocol for early firmware
versions of IXXAT USB-to-CAN adapters. It adds support for classic CAN 2.0b
frames and sets up bittiming constants and control modes.

>     The exported usb2can_cl1 adapter descriptor references the CL1
>     open/close/start/stop callbacks and the CL1 bittiming constants.

[Severity: Medium]
Is this description accurate? The commit message mentions that the descriptor
references open, close, start, and stop callbacks, but looking at the
definition of usb2can_cl1 below, only get_ctrl_caps and init_ctrl are present.

> diff --git a/drivers/net/can/usb/ixxat_usb/ixxat_usb_cl1.c b/drivers/net/can/usb/ixxat_usb/ixxat_usb_cl1.c
> new file mode 100644
> index 0000000000000..c1e337fc3b912
> --- /dev/null
> +++ b/drivers/net/can/usb/ixxat_usb/ixxat_usb_cl1.c
[ ... ]
> +const struct ixxat_usb_adapter usb2can_cl1 = {
> +	.clock = IXXAT_USB_CLOCK,
> +	.bt = &usb2can_bt,
> +	.modes = IXXAT_USB_MODES,
> +	.buffer_size_rx = IXXAT_USB_BUFFER_SIZE_RX,
> +	.buffer_size_tx = IXXAT_USB_BUFFER_SIZE_TX,
> +	.ep_msg_in = {
> +		IXXAT_USB2CAN_EP1_IN,
> +		IXXAT_USB2CAN_EP2_IN,
> +		IXXAT_USB2CAN_EP3_IN,
> +		IXXAT_USB2CAN_EP4_IN,
> +		IXXAT_USB2CAN_EP5_IN
> +	},
> +	.ep_msg_out = {
> +		IXXAT_USB2CAN_EP1_OUT,
> +		IXXAT_USB2CAN_EP2_OUT,
> +		IXXAT_USB2CAN_EP3_OUT,
> +		IXXAT_USB2CAN_EP4_OUT,
> +		IXXAT_USB2CAN_EP5_OUT
> +	},
> +	.get_ctrl_caps = ixxat_usb_get_ctrl_caps,
> +	.init_ctrl = ixxat_usb_init_ctrl
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2