Re: [PATCH v6 2/4] can: rockchip: add RK3588 CAN support

--g7nujloidt2lie2b
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PATCH v6 2/4] can: rockchip: add RK3588 CAN support
MIME-Version: 1.0

On 30.07.2026 14:46:05, [email protected] wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issu=
e(s) to consider:
>
> Pre-existing issues: - [High] The rockchip_canfd driver
> unconditionally enables CAN-FD mode in the hardware, even if the user
> only requests Classic CAN mode. However, the data bit timing registers
> are only initialized if the user explicitly requests CAN-FD. This
> leaves the hardware configured to process CAN-FD frames but with
> uninitialized data bit timing, causing it to lose synchronization and
> transmit error frames, which disrupts valid CAN-FD traffic on the bus.
> --

Good point. IIRC in non CAN-FD mode, the controller switches into a much
less capable register layout and disables many features. We accept the
downsides.

regards,
Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung N=C3=BCrnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

--g7nujloidt2lie2b
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQSl+MghEFFAdY3pYJLMOmT6rpmt0gUCamxYAQAKCRDMOmT6rpmt
0nn9AP9DqV4V+X8vXOVXeyj265nB4yHt1L2ALHqLZ3lDfwOxKgD/eSLzYR6A2q7v
OgoTq3rWvjLnQ9M3e2e9Gbk9yE9/Rg4=
=w1j2
-----END PGP SIGNATURE-----

--g7nujloidt2lie2b--