[PATCH v2 1/2] can: dev: can_put_echo_skb(): use dev_kfree_skb_any()
Cunhao Lu <[email protected]> Fri, 31 Jul 2026 16:23:53 +0800
| Newsgroups | org.kernel.vger.linux-can,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
can_put_echo_skb() is a public helper used by CAN drivers, so its callers do not have a guaranteed IRQ context. kfree_skb() cannot be called from hardware interrupt context or with hardware interrupts disabled. Use dev_kfree_skb_any() for the existing skb drop paths so that they are safe regardless of the caller's IRQ context. Signed-off-by: Cunhao Lu <[email protected]> --- drivers/net/can/dev/skb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/can/dev/skb.c b/drivers/net/can/dev/skb.c index 95fcdc1026f8..d7b5a5d17ff2 100644 --- a/drivers/net/can/dev/skb.c +++ b/drivers/net/can/dev/skb.c @@ -62,7 +62,7 @@ int can_put_echo_skb(struct sk_buff *skb, struct net_device *dev, (skb->protocol != htons(ETH_P_CAN) && skb->protocol != htons(ETH_P_CANFD) && skb->protocol != htons(ETH_P_CANXL))) { - kfree_skb(skb); + dev_kfree_skb_any(skb); return 0; } @@ -90,7 +90,7 @@ int can_put_echo_skb(struct sk_buff *skb, struct net_device *dev, } else { /* locking problem with netif_stop_queue() ?? */ netdev_err(dev, "%s: BUG! echo_skb %d is occupied!\n", __func__, idx); - kfree_skb(skb); + dev_kfree_skb_any(skb); return -EBUSY; } -- 2.34.1