CAN-XL frame to not CAN-XL enabled interface

Marc Kleine-Budde <[email protected]> Fri, 31 Jul 2026 13:02:53 +0200
Newsgroups org.kernel.vger.linux-can
Message-ID <[email protected]>
--oonlxdoc2sbdefr6
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Subject: CAN-XL frame to not CAN-XL enabled interface
MIME-Version: 1.0

Vincent,

does the current code check if you send a CAN XL frame to a CAN XL
enabled interface?

On 31.07.2026 10:54:02, [email protected] wrote:
> This is a pre-existing issue, but does this code properly handle CAN XL f=
rames?
>
> If an ETH_P_CANXL frame is sent via AF_PACKET, can_dev_dropped_skb() curr=
ently
> lacks a check to drop CAN XL frames for devices that don't support CAN XL.
> When such a frame enters rkcanfd_start_xmit(), can_is_canfd_skb() returns
> false, causing the driver to treat it as a Classic CAN frame.

> Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260731-master-v=
[email protected]?part=3D1

regards,
Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung N=C3=BCrnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

--oonlxdoc2sbdefr6
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQSl+MghEFFAdY3pYJLMOmT6rpmt0gUCamyAzgAKCRDMOmT6rpmt
0sWIAQDbpl55NjZVEbYx2injOW5yFoMmmiO8oXxJrYlL3Yc6UwEA37vK7AA0h8hW
CdyNnehNmWHMFJmqoapy0hFcXaNAeAU=
=j6Nq
-----END PGP SIGNATURE-----

--oonlxdoc2sbdefr6--