Re: [PATCH v2] can: tcan4x5x: put tcan into sleep when removing driver

Marc Kleine-Budde <[email protected]> Mon, 3 Aug 2026 13:00:16 +0200
Newsgroups org.kernel.vger.linux-can
Message-ID <[email protected]>
--j72kxxi2ocwydbqk
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PATCH v2] can: tcan4x5x: put tcan into sleep when removing
 driver
MIME-Version: 1.0

On 03.08.2026 10:33:19, [email protected] wrote:
> Thank you for your contribution! Sashiko AI review found 3 potential issu=
e(s) to consider:
[...]
> - [Medium] The transceiver is not explicitly put into sleep mode via
>   SPI during driver removal if it is powered by a regulator, undermining
>   the patch's intended power savings.

Bad Bot! Read the data sheet. The transceiver/PHY is integrated into the
device, so if the regulator powers down the device, the transceiver/PHY
is powered down, too.

regards,
Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung N=C3=BCrnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

--j72kxxi2ocwydbqk
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQSl+MghEFFAdY3pYJLMOmT6rpmt0gUCanB0vAAKCRDMOmT6rpmt
0lM+AQCuhNJ42clWPAzvLZ5ZE4c8px8gVfVFIUalJVi8XSpKYAEAlbhdgRK+xlDp
b5UfPTNQvgddwIHsvpkEbvVqPpie7w0=
=sm6M
-----END PGP SIGNATURE-----

--j72kxxi2ocwydbqk--