[PATCH 1/4] can: slcan: do not allocate unused echo skb
Vincent Mailhol <[email protected]>
| Newsgroups | org.kernel.vger.linux-can,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
The slcan driver does not use the generic CAN echo skb helpers. It leaves IFF_ECHO clear and relies on the PF_CAN fallback echo path instead. There is therefore no need to allocate one generic echo skb slot for slcan. Request zero echo skb slots when allocating the CAN netdevice. Signed-off-by: Vincent Mailhol <[email protected]> --- drivers/net/can/slcan/slcan-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/can/slcan/slcan-core.c b/drivers/net/can/slcan/slcan-core.c index 7439849d5c84..546b9dcb08cc 100644 --- a/drivers/net/can/slcan/slcan-core.c +++ b/drivers/net/can/slcan/slcan-core.c @@ -826,7 +826,7 @@ static int slcan_open(struct tty_struct *tty) if (!tty->ops->write) return -EOPNOTSUPP; - dev = alloc_candev(sizeof(*sl), 1); + dev = alloc_candev(sizeof(*sl), 0); if (!dev) return -ENFILE; -- 2.54.0