Re: [PATCH v2] can: tcan4x5x: put tcan into sleep when removing driver

Hi Sean,

kernel test robot noticed the following build errors:

[auto build test ERROR on mkl-can-next/testing]
[also build test ERROR on linus/master v7.2-rc7 next-20260810]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Sean-Nyekjaer/can-tcan4x5x-put-tcan-into-sleep-when-removing-driver/20260812-163135
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git testing
patch link:    https://lore.kernel.org/r/20260803101927.17122-1-sean%40geanix.com
patch subject: [PATCH v2] can: tcan4x5x: put tcan into sleep when removing driver
config: alpha-allmodconfig (https://download.01.org/0day-ci/archive/20260812/[email protected]/config)
compiler: alpha-linux-gcc (GCC) 16.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260812/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All errors (new ones prefixed by >>):

   drivers/net/can/m_can/tcan4x5x-core.c: In function 'tcan4x5x_can_remove':
>> drivers/net/can/m_can/tcan4x5x-core.c:552:35: error: passing argument 1 of 'tcan4x5x_power_enable' from incompatible pointer type [-Wincompatible-pointer-types]
     552 |         tcan4x5x_power_enable(priv->power, 0);
         |                               ~~~~^~~~~~~
         |                                   |
         |                                   struct regulator *
   drivers/net/can/m_can/tcan4x5x-core.c:214:56: note: expected 'struct tcan4x5x_priv *' but argument is of type 'struct regulator *'
     214 | static int tcan4x5x_power_enable(struct tcan4x5x_priv *priv, int enable)
         |                                  ~~~~~~~~~~~~~~~~~~~~~~^~~~


vim +/tcan4x5x_power_enable +552 drivers/net/can/m_can/tcan4x5x-core.c

5443c226ba9166 drivers/net/can/m_can/tcan4x5x.c      Dan Murphy        2019-05-09  545  
a0386bba70934d drivers/net/can/m_can/tcan4x5x-core.c Uwe Kleine-König  2022-01-23  546  static void tcan4x5x_can_remove(struct spi_device *spi)
5443c226ba9166 drivers/net/can/m_can/tcan4x5x.c      Dan Murphy        2019-05-09  547  {
5443c226ba9166 drivers/net/can/m_can/tcan4x5x.c      Dan Murphy        2019-05-09  548  	struct tcan4x5x_priv *priv = spi_get_drvdata(spi);
5443c226ba9166 drivers/net/can/m_can/tcan4x5x.c      Dan Murphy        2019-05-09  549  
ac33ffd3e2b037 drivers/net/can/m_can/tcan4x5x.c      Marc Kleine-Budde 2020-12-12  550  	m_can_class_unregister(&priv->cdev);
5443c226ba9166 drivers/net/can/m_can/tcan4x5x.c      Dan Murphy        2019-05-09  551  
c81d0b6ca66547 drivers/net/can/m_can/tcan4x5x.c      Marc Kleine-Budde 2020-08-10 @552  	tcan4x5x_power_enable(priv->power, 0);
c81d0b6ca66547 drivers/net/can/m_can/tcan4x5x.c      Marc Kleine-Budde 2020-08-10  553  
ac33ffd3e2b037 drivers/net/can/m_can/tcan4x5x.c      Marc Kleine-Budde 2020-12-12  554  	m_can_class_free_dev(priv->cdev.net);
5443c226ba9166 drivers/net/can/m_can/tcan4x5x.c      Dan Murphy        2019-05-09  555  }
5443c226ba9166 drivers/net/can/m_can/tcan4x5x.c      Dan Murphy        2019-05-09  556  

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki