Re: [PATCH net] can: can327: Fix stack out-of-bounds write in can327_handle_prompt()
Max Staudt <[email protected]>
| Newsgroups | org.kernel.vger.linux-can,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On 8/19/26 3:23 PM, Marc Kleine-Budde wrote: > On 19.08.2026 14:42:01, Baul Lee wrote: >> can327_handle_prompt() hexdumps the frame queued for transmission, two >> hex characters per payload byte, into an 18-byte on-stack buffer sized >> for a classical 8-byte payload. The loop runs frame->len times without a >> clamp, and frame is a struct can_frame copied verbatim from the skb >> passed to can327_netdev_start_xmit(). >> >> A CAN XL frame aliases struct can_frame such that canxl_frame.flags, > > I've a patch pending, that drops CAN_XL frames on non CAN_XL interfaces: > > https://lore.kernel.org/all/[email protected]/ > > So I think this patch is not needed. Agreed, thanks! Just in case you decide to take Baul's patch anyway, here is my Reviewed-by: Max Staudt <[email protected]>