Re: [PATCH v4 0/7] smb/client: fix fallocate and allocation accounting

With all patches (including smb/client: preserve errors from
smb2_set_sparse) except
    smb/client: verify allocation after EOF-extending fallocate
tests 496 and 701 fail

On Sat, Jun 27, 2026 at 1:06 PM Steve French <[email protected]> wrote:
>
> Everything passes with six of these seven as long as I leave out:
>
>           smb/client: verify allocation after EOF-extending fallocate
>
> and revert the earlier patch:
>
>           smb/client: preserve errors from smb2_set_sparse()
>
> On Fri, Jun 26, 2026 at 8:47 AM Huiwen He <[email protected]> wrote:
> >
> > From: Huiwen He <[email protected]>
> >
> > Changes in v4:
> >
> > - Add new patch 1 to refresh i_blocks after successful duplicate-extents.
> >   This fixes stale st_blocks after reflink and avoids the generic/370
> >   swapon hole-check regression.
> >
> > The following patches from v2 have already been merged into cifs-2.6.git for-next:
> >   - smb/client: do not account EOF extension as allocation
> >   - smb/client: preserve errors from smb2_set_sparse()
> >   - smb/client: name the default fallocate mode
> >
> > Link to v3:
> > https://lore.kernel.org/linux-cifs/[email protected]
> >
> > Link to v2:
> > https://lore.kernel.org/linux-cifs/[email protected]
> >
> > Thanks,
> > Huiwen
> >
> > Huiwen He (7):
> >   smb/client: refresh allocation size after duplicate extents
> >   smb/client: handle smb2_set_sparse() failure in EOF-extending
> >     fallocate
> >   smb/client: handle smb2_set_sparse() failure in non-extending
> >     fallocate
> >   smb/client: handle overlapping allocated ranges in fallocate
> >   smb/client: reduce fallocate zero buffer allocation
> >   smb/client: emulate small mode 0 fallocate ranges at or past EOF
> >   smb/client: verify allocation after EOF-extending fallocate
> >
> >  fs/smb/client/smb2ops.c   | 169 +++++++++++++++++++++++++++++++++-----
> >  fs/smb/client/smb2pdu.c   |  19 +++++
> >  fs/smb/client/smb2proto.h |   3 +
> >  fs/smb/common/fscc.h      |   5 ++
> >  4 files changed, 175 insertions(+), 21 deletions(-)
> >
> > --
> > 2.43.0
> >
>
>
> --
> Thanks,
>
> Steve



-- 
Thanks,

Steve