Re: [PATCH] smb: client: fix overflow in passthrough ioctl bounds check
Markus Elfring <[email protected]>
| Newsgroups | org.kernel.vger.linux-cifs,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
> smb2_ioctl_query_info() validates the PASSTHRU_FSCTL response payload
> before copying it to userspace.
…
> Use size_add() for the offset plus length check so overflow is treated as
> out of bounds.
>
> Fixes: 2b1116bbe898 ("CIFS: Use common error handling code in smb2_ioctl_query_info()")
Were implementation details improvable already before this commit?
Regards,
Markus